Skip to content

Virtual pins handlers #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Virtual pins handlers #2

wants to merge 1 commit into from

Conversation

neu-rah
Copy link

@neu-rah neu-rah commented Oct 20, 2017

#1

defining alternative pin handling functions and respective triggers
installed into pin functions

all changes wraped by #defines

alternative handlers require compilation with VIRTUAL_PINS defined

digital pin functions triggers require both VIRTUAL_PINS and
VPINS_TRIGGER defined

eventually we can extend pin tables instead of installing the triggers

arduino#1

defining alternative pin handling functions and respective triggers
installed into pin functions

all changes wraped by #defines

alternative handlers require compilation with VIRTUAL_PINS defined

digital pin functions triggers require both VIRTUAL_PINS and
VPINS_TRIGGER defined

eventually we can extend pin tables instead of installing the triggers
facchinm pushed a commit that referenced this pull request Oct 19, 2018
facchinm added a commit that referenced this pull request Oct 19, 2018
Wire implementation with related Serial bug-fixes
@neu-rah
Copy link
Author

neu-rah commented Jan 4, 2019

the pre-processor defines are only for testing purposes and provide an easy way of checking the impact by turning the feature on/off, after that we should remove them
this does not break compatibility with non-avr cores, they could implement it at its own pace and if desired.

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

@neu-rah
Copy link
Author

neu-rah commented Apr 24, 2021

should I remove the testing #defines? they are only there for testing purposes.
However if Arduino IDE allows compiler level defines they can remain as an option for user to include/exclude the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants